Handle AltGr (non-US keyboards) correctly on Windows Chrome/IE (issue #64) #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasieronen
force-pushed
the
issue-64-altgr
branch
2 times, most recently
from
a12ddad
to
914a2d0
Compare
pasieronen
force-pushed
the
issue-64-altgr
branch
from
914a2d0
to
d2238f6
Compare
|
Hi @amasad, First of all: great piece of software! I would like to mention though that we were facing a pretty annoying bug that is fixed by this pull request. (Namely a lot of our users weren't able to type certain characters like brackets as they have to use the AltGr key for that.) Is it maybe possible to merge this pull request in, so we can keep on using the most up to date version of jq-console? Thanks and keep up the great work! |
|
Hi @amasad, Sorry for this second notification, but I'd like to ask again whether this pull request could be merged in. It would mean a lot to us as we are currently making use of a (rather outdated) fork that's getting none of the nice new features that have been added. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.