Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security] enforce min starlette version #228

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

ryantm
Copy link
Collaborator

@ryantm ryantm commented Feb 19, 2025

Why

  • Dependabot has a security warning that is resolved after starlette 0.40.0

What changed

  • Add this indirect dependency to our pyproject.toml file and put the min version at the level where the security issue was resolved

Test plan

  • CI passes

Rollout

Describe any procedures or requirements needed to roll this out safely (or check the box below)

  • This is fully backward and forward compatible

Why
===
* Dependabot has a security warning that is resolved after starlette
0.40.0

What changed
===
* Add this indirect dependency to our pyproject.toml file and put the
min version at the level where the security issue was resolved

Test plan
===
* CI passes
@ryantm ryantm requested a review from a team as a code owner February 19, 2025 22:28
@ryantm ryantm requested review from airportyh and removed request for a team February 19, 2025 22:28
@ryantm ryantm enabled auto-merge (squash) February 19, 2025 22:29
@ryantm ryantm merged commit c4355c3 into master Feb 19, 2025
6 checks passed
@ryantm ryantm deleted the rtm-02-19-pin-starlette branch February 19, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants