-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPMRPP-87048 || Move authorization service to java 21 #283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
reviewdog
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|72| Line is longer than 100 characters (found 140).
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|72 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|73 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|74 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|75 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|77 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|78 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|79 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|81 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|82 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|83 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|84 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|85 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|86 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|87 col 3| Line contains a tab character.
//@ComponentScan(basePackages = "com.epam.reportportal.auth") | ||
//public class Swagger2Configuration { | ||
// | ||
// @Autowired |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
//public class Swagger2Configuration { | ||
// | ||
// @Autowired | ||
// private ServletContext servletContext; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// @Autowired | ||
// private ServletContext servletContext; | ||
// | ||
// @Value("${info.build.version}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// private ServletContext servletContext; | ||
// | ||
// @Value("${info.build.version}") | ||
// private String buildVersion; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// @Value("${info.build.version}") | ||
// private String buildVersion; | ||
// | ||
// @Value("${spring.application.name}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// .host(applicationName) | ||
// /* remove default endpoints from listing */ | ||
// .select() | ||
// .apis(Predicate.not(or( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// /* remove default endpoints from listing */ | ||
// .select() | ||
// .apis(Predicate.not(or( | ||
// RequestHandlerSelectors.basePackage("org.springframework.boot"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 112).
// /* remove default endpoints from listing */ | ||
// .select() | ||
// .apis(Predicate.not(or( | ||
// RequestHandlerSelectors.basePackage("org.springframework.boot"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// .select() | ||
// .apis(Predicate.not(or( | ||
// RequestHandlerSelectors.basePackage("org.springframework.boot"), | ||
// RequestHandlerSelectors.basePackage("org.springframework.cloud"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 113).
// .select() | ||
// .apis(Predicate.not(or( | ||
// RequestHandlerSelectors.basePackage("org.springframework.boot"), | ||
// RequestHandlerSelectors.basePackage("org.springframework.cloud"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// .apis(Predicate.not(or( | ||
// RequestHandlerSelectors.basePackage("org.springframework.boot"), | ||
// RequestHandlerSelectors.basePackage("org.springframework.cloud"), | ||
// RequestHandlerSelectors.basePackage("org.springframework.security.oauth2.provider.endpoint") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 140).
// .apis(Predicate.not(or( | ||
// RequestHandlerSelectors.basePackage("org.springframework.boot"), | ||
// RequestHandlerSelectors.basePackage("org.springframework.cloud"), | ||
// RequestHandlerSelectors.basePackage("org.springframework.security.oauth2.provider.endpoint") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// RequestHandlerSelectors.basePackage("org.springframework.boot"), | ||
// RequestHandlerSelectors.basePackage("org.springframework.cloud"), | ||
// RequestHandlerSelectors.basePackage("org.springframework.security.oauth2.provider.endpoint") | ||
// ))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// RequestHandlerSelectors.basePackage("org.springframework.cloud"), | ||
// RequestHandlerSelectors.basePackage("org.springframework.security.oauth2.provider.endpoint") | ||
// ))) | ||
// .build(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// RequestHandlerSelectors.basePackage("org.springframework.security.oauth2.provider.endpoint") | ||
// ))) | ||
// .build(); | ||
// //@formatter:on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// | ||
// private static <T> Predicate<T> or(Predicate<? super T>... predicates) { | ||
// Predicate<T> result = x -> false; | ||
// for (Predicate<? super T> predicate : predicates) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// private static <T> Predicate<T> or(Predicate<? super T>... predicates) { | ||
// Predicate<T> result = x -> false; | ||
// for (Predicate<? super T> predicate : predicates) { | ||
// result = result.or(predicate); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// Predicate<T> result = x -> false; | ||
// for (Predicate<? super T> predicate : predicates) { | ||
// result = result.or(predicate); | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// for (Predicate<? super T> predicate : predicates) { | ||
// result = result.or(predicate); | ||
// } | ||
// return result; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
// result = result.or(predicate); | ||
// } | ||
// return result; | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
No description provided.