Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-87048 || Move authorization service to java 21 #283

Closed
wants to merge 4 commits into from

Conversation

APiankouski
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|72| Line is longer than 100 characters (found 140).
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|72 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|73 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|74 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|75 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|77 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|78 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|79 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|81 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|82 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|83 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|84 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|85 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|86 col 3| Line contains a tab character.
src/main/java/com/epam/reportportal/auth/config/Swagger2Configuration.java|87 col 3| Line contains a tab character.

//@ComponentScan(basePackages = "com.epam.reportportal.auth")
//public class Swagger2Configuration {
//
// @Autowired

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

//public class Swagger2Configuration {
//
// @Autowired
// private ServletContext servletContext;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

// @Autowired
// private ServletContext servletContext;
//
// @Value("${info.build.version}")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

// private ServletContext servletContext;
//
// @Value("${info.build.version}")
// private String buildVersion;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

// @Value("${info.build.version}")
// private String buildVersion;
//
// @Value("${spring.application.name}")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

// .host(applicationName)
// /* remove default endpoints from listing */
// .select()
// .apis(Predicate.not(or(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

// /* remove default endpoints from listing */
// .select()
// .apis(Predicate.not(or(
// RequestHandlerSelectors.basePackage("org.springframework.boot"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 112).

// /* remove default endpoints from listing */
// .select()
// .apis(Predicate.not(or(
// RequestHandlerSelectors.basePackage("org.springframework.boot"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

// .select()
// .apis(Predicate.not(or(
// RequestHandlerSelectors.basePackage("org.springframework.boot"),
// RequestHandlerSelectors.basePackage("org.springframework.cloud"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 113).

// .select()
// .apis(Predicate.not(or(
// RequestHandlerSelectors.basePackage("org.springframework.boot"),
// RequestHandlerSelectors.basePackage("org.springframework.cloud"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

// .apis(Predicate.not(or(
// RequestHandlerSelectors.basePackage("org.springframework.boot"),
// RequestHandlerSelectors.basePackage("org.springframework.cloud"),
// RequestHandlerSelectors.basePackage("org.springframework.security.oauth2.provider.endpoint")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 140).

// .apis(Predicate.not(or(
// RequestHandlerSelectors.basePackage("org.springframework.boot"),
// RequestHandlerSelectors.basePackage("org.springframework.cloud"),
// RequestHandlerSelectors.basePackage("org.springframework.security.oauth2.provider.endpoint")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

// RequestHandlerSelectors.basePackage("org.springframework.boot"),
// RequestHandlerSelectors.basePackage("org.springframework.cloud"),
// RequestHandlerSelectors.basePackage("org.springframework.security.oauth2.provider.endpoint")
// )))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

// RequestHandlerSelectors.basePackage("org.springframework.cloud"),
// RequestHandlerSelectors.basePackage("org.springframework.security.oauth2.provider.endpoint")
// )))
// .build();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

// RequestHandlerSelectors.basePackage("org.springframework.security.oauth2.provider.endpoint")
// )))
// .build();
// //@formatter:on

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

//
// private static <T> Predicate<T> or(Predicate<? super T>... predicates) {
// Predicate<T> result = x -> false;
// for (Predicate<? super T> predicate : predicates) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

// private static <T> Predicate<T> or(Predicate<? super T>... predicates) {
// Predicate<T> result = x -> false;
// for (Predicate<? super T> predicate : predicates) {
// result = result.or(predicate);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

// Predicate<T> result = x -> false;
// for (Predicate<? super T> predicate : predicates) {
// result = result.or(predicate);
// }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

// for (Predicate<? super T> predicate : predicates) {
// result = result.or(predicate);
// }
// return result;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

// result = result.or(predicate);
// }
// return result;
// }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@APiankouski APiankouski deleted the EPMRPP-87048 branch November 13, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant