Epmrpp 87165 logger #323

APiankouski · 2024-08-13T14:28:24Z

No description provided.

github-actions · 2024-08-13T14:28:51Z

src/main/java/com/epam/reportportal/auth/integration/ldap/LdapAuthProvider.java

+        pbkdf2HmacSha512Encoder.setAlgorithm(
+            it.equalsIgnoreCase("PBKDF2_SHA256") ? SecretKeyFactoryAlgorithm.PBKDF2WithHmacSHA256
+                : SecretKeyFactoryAlgorithm.PBKDF2WithHmacSHA512);
+        delegate = new DelegatingPasswordEncoder("bcrypt", Map.of(it, pbkdf2HmacSha512Encoder)); //it == PBKDF2_SHA512


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 118).

github-actions · 2024-08-13T14:40:22Z

src/main/java/com/epam/reportportal/auth/integration/ldap/LdapAuthProvider.java

+        pbkdf2Encoder.setAlgorithm(
+            it.equalsIgnoreCase("PBKDF2_SHA256") ? SecretKeyFactoryAlgorithm.PBKDF2WithHmacSHA256
+                : SecretKeyFactoryAlgorithm.PBKDF2WithHmacSHA512);
+        delegate = new DelegatingPasswordEncoder(it, Map.of(it, pbkdf2Encoder)); //it == PBKDF2_SHA512


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 102).

github-actions · 2024-08-13T15:03:22Z

...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.epam.reportportal.auth.integration.parameter;


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck> _{reported by reviewdog 🐶}
'package' should be separated from previous line.

github-actions · 2024-08-13T15:03:22Z

...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+import org.springframework.security.crypto.password.Pbkdf2PasswordEncoder.SecretKeyFactoryAlgorithm;
+import org.springframework.security.crypto.scrypt.SCryptPasswordEncoder;
+
+/**


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> _{reported by reviewdog 🐶}
Summary javadoc is missing.

github-actions · 2024-08-13T15:03:22Z

...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+ */
+public class CustomPasswordEncoderFactory {
+
+  public static PasswordEncoder createDelegatingPasswordEncoder() {


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

github-actions · 2024-08-13T15:03:22Z

...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    encoders.put(encodingId, new BCryptPasswordEncoder());
+    encoders.put("ldap", new org.springframework.security.crypto.password.LdapShaPasswordEncoder());
+    encoders.put("MD4", new org.springframework.security.crypto.password.Md4PasswordEncoder());
+    encoders.put("MD5", new org.springframework.security.crypto.password.MessageDigestPasswordEncoder("MD5"));


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 110).

github-actions · 2024-08-13T15:03:22Z

...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    encoders.put("ldap", new org.springframework.security.crypto.password.LdapShaPasswordEncoder());
+    encoders.put("MD4", new org.springframework.security.crypto.password.Md4PasswordEncoder());
+    encoders.put("MD5", new org.springframework.security.crypto.password.MessageDigestPasswordEncoder("MD5"));
+    encoders.put("noop", org.springframework.security.crypto.password.NoOpPasswordEncoder.getInstance());


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 105).

github-actions · 2024-08-13T15:03:23Z

...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    Pbkdf2PasswordEncoder PBKDF2_SHA256 = new Pbkdf2PasswordEncoder();
+    PBKDF2_SHA256.setAlgorithm(SecretKeyFactoryAlgorithm.PBKDF2WithHmacSHA256);
+    encoders.put("PBKDF2_SHA256", PBKDF2_SHA256);
+    Pbkdf2PasswordEncoder PBKDF2_SHA512 = new Pbkdf2PasswordEncoder();


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> _{reported by reviewdog 🐶}
Abbreviation in name 'PBKDF2_SHA512' must contain no more than '1' consecutive capital letters.

github-actions · 2024-08-13T15:03:23Z

...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    Pbkdf2PasswordEncoder PBKDF2_SHA256 = new Pbkdf2PasswordEncoder();
+    PBKDF2_SHA256.setAlgorithm(SecretKeyFactoryAlgorithm.PBKDF2WithHmacSHA256);
+    encoders.put("PBKDF2_SHA256", PBKDF2_SHA256);
+    Pbkdf2PasswordEncoder PBKDF2_SHA512 = new Pbkdf2PasswordEncoder();


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.naming.LocalVariableNameCheck> _{reported by reviewdog 🐶}
Local variable name 'PBKDF2_SHA512' must match pattern '^a-z?$'.

github-actions · 2024-08-13T15:03:23Z

...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    PBKDF2_SHA512.setAlgorithm(SecretKeyFactoryAlgorithm.PBKDF2WithHmacSHA512);
+    encoders.put("PBKDF2_SHA512", new Pbkdf2PasswordEncoder());
+    encoders.put("scrypt", new SCryptPasswordEncoder());
+    encoders.put("SHA-1", new org.springframework.security.crypto.password.MessageDigestPasswordEncoder("SHA-1"));


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 114).

github-actions · 2024-08-13T15:03:23Z

...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    encoders.put("SHA-1", new org.springframework.security.crypto.password.MessageDigestPasswordEncoder("SHA-1"));
+    encoders.put("SHA-256",
+        new org.springframework.security.crypto.password.MessageDigestPasswordEncoder("SHA-256"));
+    encoders.put("sha256", new org.springframework.security.crypto.password.StandardPasswordEncoder());


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 103).

github-actions · 2024-08-13T15:03:23Z

src/main/java/com/epam/reportportal/auth/integration/ldap/LdapAuthProvider.java

@@ -107,7 +117,9 @@ protected AuthenticationProvider getDelegate() {
       * This is why we just wrap old encoder with new one interface
       * New encoder cannot be used everywhere since it does not have implementation for LDAP
       */
-      final PasswordEncoder delegate = PasswordEncoderFactories.createDelegatingPasswordEncoder();
+      LOGGER.error("PASSWORD_ENCODER_TYPE: " + it);
+      final PasswordEncoder delegate = CustomPasswordEncoderFactory.createDelegatingPasswordEncoder();


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 102).

...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    String encodingId = "bcrypt";
+    Map<String, PasswordEncoder> encoders = new HashMap<>();
+    encoders.put(encodingId, new BCryptPasswordEncoder());
+    encoders.put("ldap", new org.springframework.security.crypto.password.LdapShaPasswordEncoder());


...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    encoders.put("ldap", new org.springframework.security.crypto.password.LdapShaPasswordEncoder());
+    encoders.put("MD4", new org.springframework.security.crypto.password.Md4PasswordEncoder());
+    encoders.put("MD5", new org.springframework.security.crypto.password.MessageDigestPasswordEncoder("MD5"));
+    encoders.put("noop", org.springframework.security.crypto.password.NoOpPasswordEncoder.getInstance());


...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    Pbkdf2PasswordEncoder PBKDF2_SHA512 = new Pbkdf2PasswordEncoder();
+    PBKDF2_SHA512.setAlgorithm(SecretKeyFactoryAlgorithm.PBKDF2WithHmacSHA512);
+    encoders.put("PBKDF2_SHA512", new Pbkdf2PasswordEncoder());
+    encoders.put("scrypt", new SCryptPasswordEncoder());


...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    encoders.put("scrypt", new SCryptPasswordEncoder());
+    encoders.put("SHA-1", new org.springframework.security.crypto.password.MessageDigestPasswordEncoder("SHA-1"));
+    encoders.put("SHA-256",
+        new org.springframework.security.crypto.password.MessageDigestPasswordEncoder("SHA-256"));


...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    encoders.put("SHA-1", new org.springframework.security.crypto.password.MessageDigestPasswordEncoder("SHA-1"));
+    encoders.put("SHA-256",
+        new org.springframework.security.crypto.password.MessageDigestPasswordEncoder("SHA-256"));
+    encoders.put("sha256", new org.springframework.security.crypto.password.StandardPasswordEncoder());


github-actions · 2024-08-13T15:33:44Z

...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+ */
+public class CustomPasswordEncoderFactory {
+
+  public static Map<String, PasswordEncoder> createDelegatingPasswordEncoder() {


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

github-actions · 2024-08-13T15:33:44Z

src/main/java/com/epam/reportportal/auth/integration/ldap/LdapAuthProvider.java

@@ -107,7 +117,9 @@ protected AuthenticationProvider getDelegate() {
       * This is why we just wrap old encoder with new one interface
       * New encoder cannot be used everywhere since it does not have implementation for LDAP
       */
-      final PasswordEncoder delegate = PasswordEncoderFactories.createDelegatingPasswordEncoder();
+      LOGGER.error("PASSWORD_ENCODER_TYPE: " + it);
+      final PasswordEncoder delegate = CustomPasswordEncoderFactory.createDelegatingPasswordEncoder().get(it);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 110).

github-actions · 2024-08-14T06:56:20Z

src/main/java/com/epam/reportportal/auth/integration/ldap/LdapAuthProvider.java

@@ -107,16 +117,23 @@ protected AuthenticationProvider getDelegate() {
       * This is why we just wrap old encoder with new one interface
       * New encoder cannot be used everywhere since it does not have implementation for LDAP
       */
-      final PasswordEncoder delegate = PasswordEncoderFactories.createDelegatingPasswordEncoder();
+      LOGGER.error("PASSWORD_ENCODER_TYPE: " + it);
+      final PasswordEncoder delegate = CustomPasswordEncoderFactory.createDelegatingPasswordEncoder().get(it.toLowerCase());


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 124).

This reverts commit 645f375.

github-actions · 2024-08-14T10:23:25Z

...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    encoders.put("bcrypt", new BCryptPasswordEncoder());
+    encoders.put("ldap", new org.springframework.security.crypto.password.LdapShaPasswordEncoder());
+    encoders.put("md4", new org.springframework.security.crypto.password.Md4PasswordEncoder());
+    encoders.put("md5", new org.springframework.security.crypto.password.MessageDigestPasswordEncoder("MD5"));


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 110).

github-actions · 2024-08-14T10:23:25Z

...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    PBKDF2_SHA512.setAlgorithm(SecretKeyFactoryAlgorithm.PBKDF2WithHmacSHA512);
+    encoders.put("pbkdf2_sha512", new Pbkdf2PasswordEncoder());
+    encoders.put("scrypt", new SCryptPasswordEncoder());
+    encoders.put("sha-1", new org.springframework.security.crypto.password.MessageDigestPasswordEncoder("SHA-1"));


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 114).

...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    Map<String, PasswordEncoder> encoders = new HashMap<>();
+    encoders.put("bcrypt", new BCryptPasswordEncoder());
+    encoders.put("ldap", new org.springframework.security.crypto.password.LdapShaPasswordEncoder());
+    encoders.put("md4", new org.springframework.security.crypto.password.Md4PasswordEncoder());


...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    encoders.put("bcrypt", new BCryptPasswordEncoder());
+    encoders.put("ldap", new org.springframework.security.crypto.password.LdapShaPasswordEncoder());
+    encoders.put("md4", new org.springframework.security.crypto.password.Md4PasswordEncoder());
+    encoders.put("md5", new org.springframework.security.crypto.password.MessageDigestPasswordEncoder("MD5"));


...main/java/com/epam/reportportal/auth/integration/parameter/CustomPasswordEncoderFactory.java

+    PBKDF2_SHA512.setAlgorithm(SecretKeyFactoryAlgorithm.PBKDF2WithHmacSHA512);
+    encoders.put("pbkdf2_sha512", new Pbkdf2PasswordEncoder());
+    encoders.put("scrypt", new SCryptPasswordEncoder());
+    encoders.put("sha-1", new org.springframework.security.crypto.password.MessageDigestPasswordEncoder("SHA-1"));


sonarqubecloud · 2024-08-14T17:19:58Z

Quality Gate failed

Failed conditions
7 Security Hotspots
D Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

APiankouski added 2 commits August 13, 2024 14:40

EPMRPP-87165 || Add possibility to use PBKDF2 encryption for LDAP

07f3361

EPMRPP-87165 || Add logs

6b772d9

github-actions bot reviewed Aug 13, 2024

View reviewed changes

EPMRPP-87165 || Add logs

92ca1fa

github-actions bot reviewed Aug 13, 2024

View reviewed changes

APiankouski added 2 commits August 13, 2024 17:46

EPMRPP-87165 || Add logs

b678751

EPMRPP-87165 || Add logs

75fd071

github-actions bot reviewed Aug 13, 2024

View reviewed changes

github-advanced-security bot found potential problems Aug 13, 2024

View reviewed changes

EPMRPP-87165 || Add logs

6af1169

github-actions bot reviewed Aug 13, 2024

View reviewed changes

EPMRPP-87165 || Add logs

8d0f4cf

github-actions bot reviewed Aug 14, 2024

View reviewed changes

APiankouski added 3 commits August 14, 2024 12:06

EPMRPP-87165 || Add logs

645f375

Revert "EPMRPP-87165 || Add logs"

f8921a3

This reverts commit 645f375.

EPMRPP-87165 || Add logs

d920531

github-actions bot reviewed Aug 14, 2024

View reviewed changes

github-advanced-security bot found potential problems Aug 14, 2024

View reviewed changes

EPMRPP-87165 || Add logs

a1b2a65

APiankouski closed this Aug 26, 2024

APiankouski deleted the EPMRPP-87165-logger branch August 26, 2024 09:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Epmrpp 87165 logger #323

Epmrpp 87165 logger #323

APiankouski commented Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 13, 2024

github-actions bot Aug 14, 2024

github-actions bot Aug 14, 2024

github-actions bot Aug 14, 2024

sonarqubecloud bot commented Aug 14, 2024

Epmrpp 87165 logger #323

Epmrpp 87165 logger #323

Conversation

APiankouski commented Aug 13, 2024

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot Aug 14, 2024

Choose a reason for hiding this comment

github-actions bot Aug 14, 2024

Choose a reason for hiding this comment

github-actions bot Aug 14, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Aug 14, 2024

Quality Gate failed