-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable viewing video attachments #3999
base: develop
Are you sure you want to change the base?
enable viewing video attachments #3999
Conversation
Most of the solution is copied and modified from the Image viewer modal. This solution uses the HTML5 video implementation. The only thing that I've found so far is that there is not "Video" attachment image. I have no idea how to exactly generate them, that is why I used the HTML image. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3999 +/- ##
===========================================
+ Coverage 60.11% 60.15% +0.04%
===========================================
Files 80 80
Lines 875 876 +1
Branches 128 128
===========================================
+ Hits 526 527 +1
Misses 321 321
Partials 28 28 ☔ View full report in Codecov by Sentry. |
Hello @LyubomirStoimchev ! |
…e-ui into feature/video-viewer
Quality Gate passedIssues Measures |
PR Checklist
develop
for features/bugfixes, other if mentioned in the task)npm run lint
) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.npm run build
)?manage:translations
script?Visuals
report-portal-video-viewer.mov