Prepare for securesystemslib v1.0.0 #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kairoaraujo
added a commit
to kairoaraujo/repository-service-tuf-worker
that referenced
this pull request
May 15, 2024
Update all dependencies and pin securesystemslib to 0.31.0,<1.0.0 This will allow the deps to be updated. This is for the release before making RSTUF compatible with securesystemlib 1.0.0 (repository-service-tuf#507) Signed-off-by: Kairo Araujo <[email protected]>
* Update securesystemslib 1.0.0 in requirements*.txt files -> requires pinning a dev version of tuf TODO: - adopt in Pipfile (I tried, but `pipenv lock` was taking way too long for my taste) - update tuf when theupdateframework/python-tuf#2617 is released * Remove local keyvault service, which makes heavy use of legacy securesystemslib interfaces, which are no longer available in 1.0.0. TODO: - adopt in docs, config, etc - consider removing obsolete IKeyVault * Remove keyvault initialisation in MetadatRepository, which would try to load local key vault in tests, given the current configs (see TODO above) * Adopt removal in tests, just enough, so that they pass. TODO: - check if the tests still make sense * Drop registration of CryptoSigner and use its new uri scheme "file2" in SignerStore. "file2" can be used like "file", but only for non-encrypted key files, which is all we care for in the worker. "file2" can also be used like "fn" from the custom "FileNameSigner", i.e. with a directory specified via envvar. TODO: - consider only using "file2" and dropping the custom "FileNameSigner" (or only using it to ovverride the scheme name and the envvar name) Signed-off-by: Lukas Puehringer <[email protected]>
Signed-off-by: Kairo Araujo <[email protected]>
Signed-off-by: Kairo Araujo <[email protected]>
Signed-off-by: Kairo Araujo <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 14 -1
Lines 1071 1072 +1
=========================================
+ Hits 1071 1072 +1 ☔ View full report in Codecov by Sentry. |
kairoaraujo
previously approved these changes
Jul 26, 2024
MVrachev
previously approved these changes
Jul 26, 2024
Signed-off-by: Kairo Araujo <[email protected]>
kairoaraujo
approved these changes
Jul 26, 2024
MVrachev
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocks on next tuf release (theupdateframework/python-tuf#2617)
Updates securesystemslib 1.0.0 in requirements*.txt files -> requires pinning a dev version of tuf
pipenv lockwas taking way too long for my taste)Removes local keyvault service, which makes heavy use of legacy securesystemslib interfaces, which are no longer available in 1.0.0.
Removes keyvault initialisation in MetadatRepository, which would try to load local key vault in tests, given the current configs
Adopts removal in tests, just enough, so that they pass.
Drops registration of CryptoSigner and use sits new uri scheme "file2" in
SignerStore. "file2" can be used like "file", but only for non-encrypted key files, which is all we care for in the worker. "file2" can also be used like "fn" from the custom "FileNameSigner", i.e. with a directory specified via envvar.