Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom Delegation(Target) Roles #592

Conversation

kairoaraujo
Copy link
Member

@kairoaraujo kairoaraujo commented Sep 7, 2024

It starts with a simple fix in the Database Schema:

  • Include rolename as unique to avoid duplications
  • Include column to set Target Role as active
  • Implement several CRUD to handle inactive roles

Implements the Custom Delegation Roles

  • Add support to custom delegation roles during bootstrap
  • Add support for using offline and online keys in the custom delegations roles
  • Add support for adding extra delegation roles afterwards
  • Add support for updating delegation roles
  • Add support for deleting delegation roles

TODO:

  • Tests: It just fixes errors for the tests, it requires a re-implementation of tests.

NOTE: We will prioritize the functions tests (FT) to this feature which prevent regrations or breaking the compatibility with BINS.
We will implement unit tests as improvement for development process.

See: FT propose: repository-service-tuf/repository-service-tuf#817

kairoaraujo and others added 3 commits September 6, 2024 21:00
- Include rolename as unique to avoid duplications
- Include column to set Target Role as active
- Implement several CRUD to handle inactive roles

Signed-off-by: Kairo Araujo <[email protected]>
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 15.42857% with 296 lines in your changes missing coverage. Please review.

Project coverage is 75.24%. Comparing base (714a29d) to head (4b4ffdf).
Report is 98 commits behind head on main.

Files with missing lines Patch % Lines
repository_service_tuf_worker/repository.py 14.49% 289 Missing ⚠️
...pository_service_tuf_worker/models/targets/crud.py 30.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main     #592       +/-   ##
============================================
- Coverage   100.00%   75.24%   -24.76%     
============================================
  Files           15       14        -1     
  Lines         1071     1317      +246     
============================================
- Hits          1071      991       -80     
- Misses           0      326      +326     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kairoaraujo
Copy link
Member Author

Suppressed by #593 (branch in the upstream, to show the FT)

@kairoaraujo kairoaraujo closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant