Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a couple of datasets to skip_datasets #35

Merged
merged 7 commits into from
Jul 2, 2021
Merged

adds a couple of datasets to skip_datasets #35

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
748c4ac
minor fix on search_datasets function
apkrelling Jun 14, 2021
0265d7e
add UNH_CML to skip_datasets list
apkrelling Jun 14, 2021
583e08b
add altitude to skip_stdnames
apkrelling Jun 14, 2021
5ac1275
add UNH_WBD to skip_datasets
apkrelling Jun 14, 2021
39157ec
small fixes to search_datasets
apkrelling Jul 1, 2021
9dff0da
add stdnames to skip_stdnames list
apkrelling Jul 1, 2021
58e3a8a
improve readability on get_valid_stdnames
apkrelling Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion erddap_app/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@
"zoom": 6,
"max_time": now,
"min_time": now.subtract(weeks=2),
"skip_datasets": ["cwwcNDBCMet"],
"skip_datasets": ["cwwcNDBCMet", "UNH_CML", "UNH_WBD"],
},
}
3 changes: 2 additions & 1 deletion erddap_app/plots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def search_datasets(e, standard_name, cdm_data_type, min_time, max_time, skip_da
continue

except HTTPError:
df = []
pass
Copy link
Member

@ocefpaf ocefpaf Jun 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It this fails do we have a DataFrame to return below? Returning an empty list is not OK but maybe we should return an empty df or None. Not sure how this function is used down the pipeline to check if this makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were right. It was working in some instances, but I made new changes to the PR that make it more correct and more readable. Let me know what you think.


return df

Expand Down Expand Up @@ -164,6 +164,7 @@ def remove_qcstdnames(standard_names):
"station_name",
"time",
"offset_time",
"altitude",
]

skip_stdnames.extend(qc_stdnames)
Expand Down