Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused step defs #24

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Fix unused step defs #24

merged 8 commits into from
Jun 14, 2024

Conversation

UL-ChrisGlew
Copy link
Contributor

@UL-ChrisGlew UL-ChrisGlew commented Jun 13, 2024

🤔 What's changed?

The 'Find Unused Step Definitions' context menu should no longer show step definitions decorated with the 'StepDefinition' attribute as unused when one or more is used with a Given/Then/When.

⚡️ What's your motivation?

Fix for #22.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

I've attempted to add a new unit test to test this. This involved adding some logic to correctly add a 'StepDefinition' attribute into the 'MockableDiscoveryService' - let me know if there's any better way of doing this.

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

@UL-ChrisGlew UL-ChrisGlew requested a review from gasparnagy June 13, 2024 13:34
Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool! The code is fine.

My only request is to update the changelog. (Besides adding a line about the change, please also add a line at the end of the section starting with *Contributors of this release (in alphabetical order):* , and put your own GitHub handle there, similarly how we just started with the core project here: https://github.com/reqnroll/Reqnroll/blob/main/CHANGELOG.md?plain=1

@UL-ChrisGlew
Copy link
Contributor Author

@gasparnagy I've updated the Changelog with the requested changes.

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@gasparnagy gasparnagy merged commit 06b3c01 into main Jun 14, 2024
1 check passed
@gasparnagy gasparnagy deleted the fix-unused-step-defs branch June 14, 2024 07:14
@gasparnagy
Copy link
Contributor

@UL-ChrisGlew I added you to the group already, but you still deserve the "official" intro: 😎 Thx for the help!

Thank you for the contribution! According to our guidelines I have invited you to the Reqnroll contributors team. Congrats! 🎉 If you accept it, you will be able to make pull requests easier in the future.

You are also welcome on our discord server: https://go.reqnroll.net/discord-invite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants