Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SpecFlow extension compatibility #25

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

gasparnagy
Copy link
Contributor

@gasparnagy gasparnagy commented Jun 14, 2024

🤔 What's changed?

Made interfaces & classification names unique for the Reqnroll extension so that it does not conflict with other extensions, e.g. the SpecFlow extension.

⚡️ What's your motivation?

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I've changed the behaviour of the code
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

Copy link
Contributor

@clrudolphi clrudolphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One speculative comment about the strings used within the DeveroomClassifications.cs file. Otherwise this all quite straightforward.

@gasparnagy gasparnagy merged commit a7869f0 into main Jun 14, 2024
1 check passed
@gasparnagy gasparnagy deleted the fix-specflow-extension-compatibility branch September 17, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants