Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up invalid github URLs #27

Merged

Conversation

clrudolphi
Copy link
Contributor

🤔 What's changed?

Changed the URLs in a few error messages that would lead users to a 404 on the Github.com website. The corrections lead them now to https://reqnroll/Reqnoll.VisualStudio/issues

⚡️ What's your motivation?

Prevent user frustration.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

None of these required, simple spelling issue.

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

@clrudolphi clrudolphi requested a review from gasparnagy June 14, 2024 16:31
@ajeckmans
Copy link

Great changes. I do wonder whether we should not just include this in the changelog as well.

@Code-Grump
Copy link

Documentation is a feature as much as the software itself and contributions should be recognised, even if they're in a separate changelog.

@gasparnagy gasparnagy merged commit 9774c95 into reqnroll:main Jun 14, 2024
1 check passed
@clrudolphi clrudolphi deleted the Fix_invalid_Github_URLs_in_Error_Messages branch June 25, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants