Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend config file locations to match the locations searched for the reqnroll runtime #31

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

jdb0123
Copy link
Contributor

@jdb0123 jdb0123 commented Jul 29, 2024

🤔 What's changed?

Extension now searches for json config file in the following locations:

  • Project folder (already the case before)
  • Assembly directory
  • Two folders above assembly directory

⚡️ What's your motivation?

#17
The reqnroll runtime searched these locations.
This meant that it was possible to have a correctly compiling and running build, but the extension would not be able to find the steps in the feature files.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

As far as I can see there are currently no test covering this behaviour.
Is this actually the case?

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! I have made a few smaller comments.

Have you been able to manually check if the extension with this change finds the config file in the output folder?

@jdb0123
Copy link
Contributor Author

jdb0123 commented Aug 15, 2024

@gasparnagy

Thx! I have made a few smaller comments.

Have you been able to manually check if the extension with this change finds the config file in the output folder?

Yes I managed to get the visual studio experimental instance working (thanks to the contributing guidelines) and confirmed the config file is correctly found.

Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thx.
I forgot one small thing in my last review: Could you please add a line to the Improvements section of the CHANGELOG.md and add your github handle to the Contributors of this release section?

@jdb0123
Copy link
Contributor Author

jdb0123 commented Aug 26, 2024

This is great, thx. I forgot one small thing in my last review: Could you please add a line to the Improvements section of the CHANGELOG.md and add your github handle to the Contributors of this release section?

@gasparnagy Sure, updated.

@jdb0123
Copy link
Contributor Author

jdb0123 commented Aug 26, 2024

@gasparnagy Thanks for approving. I'm unable to merge, given I don't have write access to the repo. Would you be able to do that for me?

@gasparnagy
Copy link
Contributor

@jdb0123 Yes, I can do the merge, I just wanted to wait for the green build and got a meeting in the meantime... 😎

@gasparnagy gasparnagy merged commit 98966b4 into reqnroll:main Aug 26, 2024
1 check passed
@gasparnagy
Copy link
Contributor

@jdb0123 Thank you for the contribution! According to our guidelines I have invited you to the Reqnroll contributors team. Congrats! 🎉 If you accept it, you will be able to make pull requests easier in the future.

You are also welcome on our discord server: https://go.reqnroll.net/discord-invite

@jdb0123 jdb0123 deleted the config_file_location branch January 9, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants