-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend config file locations to match the locations searched for the reqnroll runtime #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx! I have made a few smaller comments.
Have you been able to manually check if the extension with this change finds the config file in the output folder?
Reqnroll.VisualStudio/ProjectSystem/Settings/ReqnrollProjectSettingsProvider.cs
Outdated
Show resolved
Hide resolved
Reqnroll.VisualStudio/ProjectSystem/Settings/ReqnrollProjectSettingsProvider.cs
Outdated
Show resolved
Hide resolved
Reqnroll.VisualStudio/ProjectSystem/Settings/ReqnrollProjectSettingsProvider.cs
Show resolved
Hide resolved
Yes I managed to get the visual studio experimental instance working (thanks to the contributing guidelines) and confirmed the config file is correctly found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thx.
I forgot one small thing in my last review: Could you please add a line to the Improvements
section of the CHANGELOG.md
and add your github handle to the Contributors of this release
section?
@gasparnagy Sure, updated. |
@gasparnagy Thanks for approving. I'm unable to merge, given I don't have write access to the repo. Would you be able to do that for me? |
@jdb0123 Yes, I can do the merge, I just wanted to wait for the green build and got a meeting in the meantime... 😎 |
@jdb0123 Thank you for the contribution! According to our guidelines I have invited you to the Reqnroll contributors team. Congrats! 🎉 If you accept it, you will be able to make pull requests easier in the future. You are also welcome on our discord server: https://go.reqnroll.net/discord-invite |
🤔 What's changed?
Extension now searches for json config file in the following locations:
⚡️ What's your motivation?
#17
The reqnroll runtime searched these locations.
This meant that it was possible to have a correctly compiling and running build, but the extension would not be able to find the steps in the feature files.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
As far as I can see there are currently no test covering this behaviour.
Is this actually the case?
📋 Checklist: