Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide FluentAssertions from new project wizard #60

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Hide FluentAssertions from new project wizard #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69c282c
Hide FluentAssertions from new project wizard
gasparnagy Jan 22, 2025
2dedb8d
Update CHANGELOG
gasparnagy Jan 22, 2025
73d4640
Merge branch 'main' into hide-fluent-assertions
gasparnagy Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Improvements:

* Suggestion for adding [FluentAssertions](https://github.com/fluentassertions/fluentassertions) on the new project wizard screen has been removed to avoid confusions, because FluentAssertion does not offer free use for commercial projects anymore. (#60)
* Step previews: do not convert options list parameter, e.g. '(option1|option2|option3)', to [string]

## Bug fixes:
Expand Down
2 changes: 1 addition & 1 deletion Reqnroll.VisualStudio.UI/Dialogs/AddNewReqnrollProjectDialog.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@
SelectionChanged="TestFramework_SelectionChanged" />
</StackPanel>

<StackPanel Grid.Row="2" Grid.Column="0">
<StackPanel Grid.Row="2" Grid.Column="0" Visibility="Collapsed">
<CheckBox x:Name="FluentAssertionsCheckBox" Content="Add FluentAssertions library"
IsChecked="{Binding FluentAssertionsIncluded}" />
</StackPanel>
Expand Down
7 changes: 5 additions & 2 deletions Reqnroll.VisualStudio/UI/ViewModels/AddNewReqnrollProjectViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class AddNewReqnrollProjectViewModel : INotifyPropertyChanged
{
DotNetFramework = Net8,
UnitTestFramework = MsTest,
FluentAssertionsIncluded = true
FluentAssertionsIncluded = false
};
#endif
private string _dotNetFramework = Net8;
Expand All @@ -27,7 +27,10 @@ public string DotNetFramework
}

public string UnitTestFramework { get; set; } = MsTest;
public bool FluentAssertionsIncluded { get; set; } = true;
// FluentAssertions suggestion is temporarily hidden from the UI as it is not free for commercial use anymore.
// See https://xceed.com/fluent-assertions-faq/
// Maybe we could consider suggesting https://github.com/shouldly/shouldly instead.
public bool FluentAssertionsIncluded { get; set; } = false;
public ObservableCollection<string> TestFrameworks { get; } = new(new List<string> { "MSTest", "NUnit", "xUnit" });

public event PropertyChangedEventHandler PropertyChanged;
Expand Down
Loading