Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update changelog (release 0.12.4) #288

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

alessio-locatelli
Copy link
Collaborator

No description provided.

@alessio-locatelli alessio-locatelli force-pushed the bump_version branch 2 times, most recently from ee4e648 to 0587ced Compare October 30, 2024 06:36
skip-checks:true
@alessio-locatelli
Copy link
Collaborator Author

alessio-locatelli commented Oct 30, 2024

@JWCook I have created a tag https://github.com/requests-cache/aiohttp-client-cache/releases/tag/v0.12.4 and a release https://github.com/requests-cache/aiohttp-client-cache/releases/tag/v0.12.4 via GitHub website. That did not trigger a deploy. I have an assumption that the reason is that I did not mark the release as the "latest" immediately.

I decided to run the workflow manually, but it created a pre-release: https://pypi.org/project/aiohttp-client-cache/#history
On GitLab CI, for my projects, if the latest tag points to the latest commit, the Poetry build picks up the "latest" version (not a "pre-release"). Perhaps I got confused because I expected a similar behavior.

So, the latest version on PyPI is still aiohttp-client-cache 0.12.3: https://pypi.org/project/aiohttp-client-cache/

Could you please release the latest version and point out what went wrong?

@JWCook JWCook deleted the bump_version branch October 30, 2024 15:15
@JWCook
Copy link
Member

JWCook commented Oct 30, 2024

That's quite strange! You didn't do anything incorrectly, and I saw the same thing when trying to recreate the tag. I noticed it didn't trigger the build step either. I updated the workflows to trigger on all tags (instead of tags matching v*), and it worked. No idea why! 🤷

That trigger has worked fine since I initially added it here, so something on the GitHub Actions end changed or broke since the last release on October 4. The docs don't indicate any syntax changes, though.

The pre-release behavior is defined here:

if: ${{ !startsWith(github.ref, 'refs/tags/v') }}
env:
pre-release-suffix: ${{ github.event.inputs.pre-release-suffix || 'dev' }}
pre-release-version: ${{ github.event.inputs.pre-release-version || github.run_number }}
run: |
poetry version $(poetry version -s).${{ env.pre-release-suffix }}${{ env.pre-release-version }}

I.e., "If it's not triggered by a tag, assume it's a (manual) pre-release." That could be changed if we need to do a non-tagged stable release at some point.

Anyway, 0.12.4 is on PyPI now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants