Move auth calculation into refresh_token method #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using an endpoint with no
client_secret
. I couldn't passclient_id
to the endpoint as Basic auth unless I provided it as anauth
kwarg to each request. However if theTokenExpiredError
was not raised, then thisauth
was passed through to the original request endpoint as it was not popped from kwargs (?overwriting the intended token auth).Based on the docs it seems like I should be able to pass
client_id
throughauto_refresh_kwargs
(https://requests-oauthlib.readthedocs.io/en/latest/oauth2_workflow.html). However currentlyauth
does not considerauto_refresh_kwargs
at all.Changes assume that the intended behaviour is that the token refresh auth can be provided in
auto_refresh_kwargs
else in the requestkwargs
. And that aclient_secret
is not mandatory.Note that
client_id
andclient_secret
would still be passed down from the request method askwargs
.More generally,
client_secret
should be required for token refresh byclient_id
client_id
andclient_secret
should need to be provided in every request but rather be sourced at a session level (likeauto_refresh_kwargs
) or from the client itself.