Skip to content

Commit

Permalink
Run more checks in parallel
Browse files Browse the repository at this point in the history
  • Loading branch information
jprochazk committed Feb 6, 2025
1 parent c433484 commit 834c524
Show file tree
Hide file tree
Showing 2 changed files with 101 additions and 8 deletions.
37 changes: 36 additions & 1 deletion .github/workflows/contrib_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ jobs:
- name: Rust checks & tests
run: pixi run rs-check --skip individual_crates docs_slow

misc-rerun-lints:
rerun-lints:
name: Rerun lints
runs-on: ubuntu-latest
steps:
Expand All @@ -130,15 +130,50 @@ jobs:
with:
pixi-version: v0.39.0

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.8"

- name: Rerun lints
run: pixi run lint-rerun

toml-format-check:
name: Toml format check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- uses: prefix-dev/[email protected]
with:
pixi-version: v0.39.0

- name: Toml format check
run: pixi run toml-fmt-check

check-too-large-files:
name: Check for too large files
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- uses: prefix-dev/[email protected]
with:
pixi-version: v0.39.0

- name: Check for too large files
run: pixi run check-large-files

check-example-thumbnails:
name: Check Python example thumbnails
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- uses: prefix-dev/[email protected]
with:
pixi-version: v0.39.0

- name: Check Python example thumbnails
run: pixi run ./scripts/ci/thumbnails.py check

Expand Down
72 changes: 65 additions & 7 deletions .github/workflows/reusable_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,14 @@ jobs:

# ---------------------------------------------------------------------------

misc-rerun-lints:
# NOTE: We don't want spurious failures caused by issues being closed, so this does not run on CI,
# at least for the time being.
# - name: Check for zombie TODOs
# shell: bash
# run: |
# pixi run ./scripts/zombie_todos.py --token ${{ secrets.GITHUB_TOKEN }}

rerun-lints:
name: Rerun lints
runs-on: ubuntu-latest
steps:
Expand All @@ -89,22 +96,68 @@ jobs:
- name: Rerun lints
run: pixi run lint-rerun

toml-format-check:
name: Toml format check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.ref || '' }}

- uses: prefix-dev/[email protected]
with:
pixi-version: v0.39.0

- name: Toml format check
run: pixi run toml-fmt-check

# NOTE: We don't want spurious failures caused by issues being closed, so this does not run on CI,
# at least for the time being.
# - name: Check for zombie TODOs
# shell: bash
# run: |
# pixi run ./scripts/zombie_todos.py --token ${{ secrets.GITHUB_TOKEN }}
check-too-large-files:
name: Check for too large files
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.ref || '' }}

- uses: prefix-dev/[email protected]
with:
pixi-version: v0.39.0

- name: Check for too large files
run: pixi run check-large-files

check-example-thumbnails:
name: Check Python example thumbnails
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.ref || '' }}

- uses: prefix-dev/[email protected]
with:
pixi-version: v0.39.0

- name: Check Python example thumbnails
run: pixi run ./scripts/ci/thumbnails.py check

check-example-manifest-coverage:
name: Check example manifest coverage
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.ref || '' }}

- uses: prefix-dev/[email protected]
with:
pixi-version: v0.39.0

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.8"

- name: Check example manifest coverage
run: pixi run ./scripts/check_example_manifest_coverage.py

Expand All @@ -120,6 +173,11 @@ jobs:
with:
pixi-version: v0.39.0

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.8"

- name: Run linter
run: |
# Single quoted because pixi does its own glob expansion
Expand Down

0 comments on commit 834c524

Please sign in to comment.