Add a test of memory use when logging a lot of big images #1372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating #1242
RERUN_TRACK_ALLOCATIONS=1 cargo r -p test_image_memory
It turns out that when we log normal RGBA images we store the data once in the
ArrowMsg
, and then that data is deep-cloned when put in the store. I think it is because of this:We use the ref-counted
Buffer
for everything except for 8-bit tensors (most images) and for jpegs.We have a similar problem for the
Mesh3D
component.