Require descriptors to be provided on all log calls in C++ (either explicitly or implicitly via archetype) #8853
Conversation
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
…ariants for component batches
teh-cmc
force-pushed
the
andreas/cpp/avoid-unttaged
branch
from
233ddcd to
b4bede8
Compare
There was a problem hiding this comment.
That predates this PR, but I'm not a fan of the fact that the most basic constructor allows not specifying required components now 😕.
That means there is no codepath left that pushes the user towards the sensible default, compared to e.g. in Rust where new() still enforces requirements.
| For example, colors of a point cloud can be logged without position data: | ||
|
|
||
| ```cpp | ||
| rec.log("points", rerun::Points3D().with_colors(colors)); |
There was a problem hiding this comment.
Hmmm.. I don't like pushing people towards this ("this" being an implicit partial update, as opposed to rerun::Points3D::update_fields()). If somehow executes that thing, they will end up in a very confusing situation where the viewer displays nothing...
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13049115241 |
|
that's a valid concern, let's talk about pro/con & solutions before shipping this. But at that point we need to do that as iteration anyways, so merging this as-is |
Wumpf
changed the title
Related
What
Followed the Rust example and opted out of deprecating this, instead making it a breaking change.
Iterated on the migration guide & adjusted snippets.