Automated check_transform_clamping
#8961
Conversation
teh-cmc
added
🔨 testing
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
| // Make sure we can draw stuff in the hover tables. | ||
| test_context.component_ui_registry = re_component_ui::create_component_ui_registry(); | ||
| // Also register the legacy UIs. | ||
| re_data_ui::register_component_uis(&mut test_context.component_ui_registry); |
There was a problem hiding this comment.
better suited for a follow-up: can we simply move that to the harness
(also not really needed for this test?)
There was a problem hiding this comment.
Yeah i'll do a follow-up tomorrow
| // This test checks the clamping behavior of components & instance poses on boxes & spheres. | ||
| // | ||
| // One view shows spheres, the other boxes. | ||
| // | ||
| // For both you should see: | ||
| // * 2x red (one bigger than the other) | ||
| // * 1x green | ||
| // * 2x blue (one bigger than the other) | ||
| // * NO other boxes/spheres, in particular no magenta ones! |
There was a problem hiding this comment.
realizing that we didn't do the textual description in a lot of these. I think that's good to have if for some reason we wake up and notice that the image comparision thresholds betrayed us
| raw_input | ||
| .events | ||
| .push(egui::Event::PointerMoved((150.0, 150.0).into())); | ||
| raw_input.events.push(egui::Event::MouseWheel { | ||
| unit: egui::MouseWheelUnit::Line, | ||
| delta: egui::Vec2::UP * 2.0, | ||
| modifiers: egui::Modifiers::default(), | ||
| }); |
There was a problem hiding this comment.
that's a very creative way of setting up the camera xD 👍
| modifiers: egui::Modifiers::default(), | ||
| }); | ||
| harness.run_steps(10); | ||
| harness.snapshot(&name); |
There was a problem hiding this comment.
We'll probably run into the same img comparision issues here again as on the draw order test, ci will tell
if the threshhold seems high to you (don't ask what that means ;)) please link the re_renderer antialiasing ticket
Title.