-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to cargo nextest for rust test execution #8974
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
d70bff2
to
0513a97
Compare
0513a97
to
23ae45f
Compare
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13241974117 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but see my comment + let's wait for full-check please (yes, it shouldn't matter... but, you know 😶)
f99d250
to
1c22325
Compare
@@ -253,14 +258,17 @@ def docs_slow(results: list[Result]) -> None: | |||
|
|||
def tests(results: list[Result]) -> None: | |||
# We first use `--no-run` to measure the time of compiling vs actually running | |||
results.append(run_cargo("test", "--all-targets --all-features --no-run")) | |||
results.append(run_cargo("nextest", "run --all-targets --all-features")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should ensure it is installed here or in pixi.toml and/or mention nextest in CONTRIBUTING.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mention in contributing is part of #8989
How could we ensure this in to be present in pixi I don't know though 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, you wrote "and/or" so I'll let the note in the contributing.md be sufficient for now
Nextest has a way nicer output and is a lot faster.
Performance numbers on my Mac:
warmup
cargo test --all-features --all-targets --lib --bins --tests --no-run
execution:
regular: 1m29s cargo test --all-features --all-targets --lib --bins --tests
nextest: 1m 3s cargo nextest run --all-features --all-targets
Setup of nextest as part of the ci doesn't seem to cost us anything: Entire rust setup action is at 15s right now.