Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cargo nextest for rust test execution #8974

Merged
merged 8 commits into from
Feb 11, 2025
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 7, 2025

Nextest has a way nicer output and is a lot faster.


Performance numbers on my Mac:

warmup
cargo test --all-features --all-targets --lib --bins --tests --no-run
execution:
regular: 1m29s cargo test --all-features --all-targets --lib --bins --tests
nextest: 1m 3s cargo nextest run --all-features --all-targets


Setup of nextest as part of the ci doesn't seem to cost us anything: Entire rust setup action is at 15s right now.

@Wumpf Wumpf added 🔨 testing testing and benchmarks exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
1c22325 https://rerun.io/viewer/pr/8974 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link

github-actions bot commented Feb 7, 2025

Latest documentation preview deployed successfully.

Result Commit Link
1c22325 https://landing-1zz4y9jsz-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf force-pushed the andreas/cargo-nextest branch from d70bff2 to 0513a97 Compare February 7, 2025 17:31
@Wumpf Wumpf force-pushed the andreas/cargo-nextest branch from 0513a97 to 23ae45f Compare February 10, 2025 11:14
@Wumpf Wumpf marked this pull request as ready for review February 10, 2025 13:02
@teh-cmc
Copy link
Member

teh-cmc commented Feb 10, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/13241974117

Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but see my comment + let's wait for full-check please (yes, it shouldn't matter... but, you know 😶)

.github/actions/setup-rust/action.yml Outdated Show resolved Hide resolved
@Wumpf Wumpf force-pushed the andreas/cargo-nextest branch from f99d250 to 1c22325 Compare February 11, 2025 09:07
@@ -253,14 +258,17 @@ def docs_slow(results: list[Result]) -> None:

def tests(results: list[Result]) -> None:
# We first use `--no-run` to measure the time of compiling vs actually running
results.append(run_cargo("test", "--all-targets --all-features --no-run"))
results.append(run_cargo("nextest", "run --all-targets --all-features"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should ensure it is installed here or in pixi.toml and/or mention nextest in CONTRIBUTING.md

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention in contributing is part of #8989

How could we ensure this in to be present in pixi I don't know though 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, you wrote "and/or" so I'll let the note in the contributing.md be sufficient for now

@Wumpf Wumpf merged commit 435ea46 into main Feb 11, 2025
42 checks passed
@Wumpf Wumpf deleted the andreas/cargo-nextest branch February 11, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants