Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a snapshot test for the range selection with shift-click #8990

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Feb 11, 2025

Related

What

This PR introduces a snapshot test for the shift-click / cltr-shift-click range selection behaviour in the blueprint panel.

There is a bunch of cleanups and test rig improvements on the way, included an update to the blueprint tree visitor pattern and proper support for selection buffer swapping in TestContext.

@abey79 abey79 changed the title Add a shapshot test for the range selection with shift-click Add a snapshot test for the range selection with shift-click Feb 11, 2025
@abey79 abey79 added 🔨 testing testing and benchmarks ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
f181512 https://rerun.io/viewer/pr/8990 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf self-requested a review February 11, 2025 15:32
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

splendid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🔨 testing testing and benchmarks ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants