Add general re_sorbet::SorbetSchema
#9017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
exclude from changelog
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13291750145 |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13291795215 |
emilk
force-pushed
the
emilk/sorbet-batch
branch
from
44a1d8b to
07f5f1a
Compare
emilk
force-pushed
the
emilk/sorbet-batch
branch
from
07f5f1a to
fd930c4
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13293774280 |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/13293864264 |
jprochazk
pushed a commit
that referenced
this pull request
Feb 13, 2025
### Related * Part of #8744 ### What Expand `re_sorbet` with `SorbetSchema` and `SorbetBatch` - a superset of the existing `ChunkSchema` and `ChunkBatch`. ### How I'm using a pretty ~ugly~ interesting approach of "fake inheritance": Define `A` -> `B` as: * `struct A` contains a `B` * `impl Deref<Target=B> for A` (upcasting) * `impl TryFrom<B> for A` (“downcasting”) * `impl From<A> for B` (“object slicing”) Using this notation: * `ChunkSchema` -> `SorbetSchema` * `ChunkBatch` -> `SorbetBatch` -> `arrow::RecordBatch` This means the `ChunkBatch` can be used as `SorbetBatch` but also as an `arrow::RecordBatch`. Note that there is no dynamic dispatch involved at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
re_sorbetChunk/Dataframe conversion crate handle arrow metadata #8744What
Expand
re_sorbetwithSorbetSchemaandSorbetBatch- a superset of the existingChunkSchemaandChunkBatch.How
I'm using a pretty
uglyinteresting approach of "fake inheritance":Define
A->Bas:struct Acontains aBimpl Deref<Target=B> for A(upcasting)impl TryFrom<B> for A(“downcasting”)impl From<A> for B(“object slicing”)Using this notation:
ChunkSchema->SorbetSchemaChunkBatch->SorbetBatch->arrow::RecordBatchThis means the
ChunkBatchcan be used asSorbetBatchbut also as anarrow::RecordBatch.Note that there is no dynamic dispatch involved at all.