Add handleCompletePromise helper function #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some code repetition around handling a completed durable promise. The repetition was fine, how ever this pattern will come to callbacks and tasks and we will have it in atleast 4 more places, having to write that code that many times is error prone and verbose.
This change also fixes a bug made evident by this helper funciton where we were returning the value computed by the function directly instead of the value stored in the completed durable promise.