Allow duration to be used for scheduling every #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonreinke
force-pushed
the
feature_duration
branch
from
0cdf0ae to
0849a0b
Compare
josephpage
suggested changes
Sep 26, 2017
| ) | ||
|
|
||
| assert_equal(1, Resque::Scheduler.rufus_scheduler.jobs.size) | ||
| assert_equal(1, Resque::Scheduler.scheduled_jobs.size) |
There was a problem hiding this comment.
Why not test the new job is well scheduled every 30s, and not 30m or 30ms ?
There was a problem hiding this comment.
agreed, we need to test the actual schedule that's configured in the scheduler here.
There was a problem hiding this comment.
@josephpage @iloveitaly definitely, updated!
iloveitaly
requested changes
Nov 11, 2021
| @@ -136,7 +136,7 @@ def load_schedule_job(name, config) | |||
| interval_defined = false | |||
| interval_types = %w(cron every) | |||
| interval_types.each do |interval_type| | |||
| next unless !config[interval_type].nil? && !config[interval_type].empty? | |||
| next unless !config[interval_type].nil? && !config[interval_type].to_s.empty? | |||
There was a problem hiding this comment.
@iloveitaly I believe this is since the interval type can now be Numeric and empty? is a String only.
| ) | ||
|
|
||
| assert_equal(1, Resque::Scheduler.rufus_scheduler.jobs.size) | ||
| assert_equal(1, Resque::Scheduler.scheduled_jobs.size) |
There was a problem hiding this comment.
agreed, we need to test the actual schedule that's configured in the scheduler here.
Check for empty should be done on string Format numeric every for server Fix Rubocop complaint in test
carsonreinke
force-pushed
the
feature_duration
branch
from
7871ac1 to
5093a3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature based on #605.
Since rufus-scheduler allows for numeric values for
every, durations can be used like30.minutesand1.hour.