Fix for #761, reflected XSS in delayed_schedules.erb #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickTulskie
force-pushed
the
xss-vuln
branch
from
1104ca6 to
38daa55
Compare
This was referenced Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue reported in #761 which is a reflected XSS in the delayed_schedules.erb template.
I created a POC for testing the fix here: https://gist.github.com/PatrickTulskie/48c3d3f53105ce9d247076bcf5d4f2b6
If you comment out the line that copies over the fix in the Dockerfile and use the sample POC from the reported issue against that app you'll see the vuln in action.