-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing root TMVA for high level analysis #448
base: master
Are you sure you want to change the base?
Conversation
… over a TRestDataSet
for more information, see https://pre-commit.ci
I don't think we should name all the classes using I would only use the For example, inside the sensitivity classes, I plan to have But it seems to me that I think discrimination methods usage should be unified by an abstract class In my opinion See issue #13 |
Well, I just followed the suggestions done here #392 (comment) I don't know how to proceed renaming these classes because is not clear to me the best way to add them to the repository. |
Ok, perhaps we should discuss this online |
Implementing
TMVA
methods for high level analysis, please check https://root.cern.ch/download/doc/tmva/TMVAUsersGuide.pdf for further details onTMVA
.Summary of changes:
TRestDataSetTMVA
to evaluate different TMVA methods onTRestDatasets
note that a signal and a background dataSet must be provided together with differentTMVA
methods. This class evaluate all the methods provided and generates a root file and a folder with the results.TRestDataSetTMVAClassification
to performs the classification of a givenTRestDataSet
using as input the results of the TMVA evaluation methods generated usingTRestDataSetTMVA
. An output dataset is generated by/// definining a new observable with the TMVA method e.g. BDT_score.
tmva.rml
TRestRun
andTRestDataSet