Flush config file to disk before starting Restate process #2863
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
issues/2828
branch
from
5a7b2ee to
1e9bc9e
Compare
jackkleeman
approved these changes
Mar 7, 2025
Dropping the file alone, does not guarantee that the file content is written to disk and the file being closed immediately. If the config file is not written when starting the Restate process, then it will start with the default configuration which causes the raft_metadata_cluster_chaos_test to fail every now and then. This fixes restatedev#2828.
tillrohrmann
force-pushed
the
issues/2828
branch
from
1e9bc9e to
ce72e47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping the file alone, does not guarantee that the file content is written to disk and the file being closed immediately. If the config file is not written when starting the Restate process, then it will start with the default configuration which causes the raft_metadata_cluster_chaos_test to fail every now and then.
This fixes #2828.