🐛 text instead of inner text

core/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "harambe-core"
-version = "0.44.0"
+version = "0.44.1"
 description = "Core types for harambe SDK 🐒🍌"
 authors = [
     { name = "Adam Watkins", email = "[email protected]" }

sdk/harambe/core.py

@@ -272,7 +272,7 @@ async def capture_html(
         :return: HTMLMetadata containing download URL, HTML content and inner text.
         :raises ValueError: If the specified selector doesn't match any element.
         """
-        html, inner_text = await self._get_html(selector, exclude_selectors or [])
+        html, text = await self._get_html(selector, exclude_selectors or [])
 
         downloads = await self._notify_observers(
             method="on_download",
@@ -286,7 +286,7 @@ async def capture_html(
             "url": downloads[0]["url"],
             "filename": downloads[0]["filename"],
             "html": html,
-            "inner_text": inner_text,
+            "text": text,
         }
 
     async def _get_html(
@@ -303,9 +303,9 @@ async def _get_html(
         for selector in exclude_selectors:
             for element_to_remove in soup.select(selector):
                 element_to_remove.decompose()
-        inner_text = soup.get_text(separator="\n", strip=True)
+        text = soup.get_text(separator="\n", strip=True)
 
-        return str(soup), inner_text
+        return str(soup), text
 
     async def capture_pdf(
         self,

sdk/harambe/observer.py

@@ -33,7 +33,7 @@ class DownloadMeta(TypedDict):
 
 class HTMLMetadata(DownloadMeta):
     html: str
-    inner_text: str
+    text: str
 
 
 @runtime_checkable

sdk/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "harambe-sdk"
-version = "0.44.0"
+version = "0.44.1"
 description = "Data extraction SDK for Playwright 🐒🍌"
 authors = [
     { name = "Adam Watkins", email = "[email protected]" }

sdk/test/test_e2e.py

@@ -462,7 +462,7 @@ async def scraper(sdk: SDK, *args, **kwargs):
     doc_data = observer.data[0]
     assert "<table" in doc_data["html"]
     assert "<tbody" in doc_data["html"]
-    assert "Apple" in doc_data["inner_text"]
+    assert "Apple" in doc_data["text"]
 
     # Verify download fields all available
     assert doc_data["url"]
@@ -472,8 +472,8 @@ async def scraper(sdk: SDK, *args, **kwargs):
     table_data = observer.data[1]
     assert "<tbody" in doc_data["html"]
     assert "<thead" not in table_data["html"]
-    assert "Price" not in table_data["inner_text"]
-    assert "Apple" in table_data["inner_text"]
+    assert "Price" not in table_data["text"]
+    assert "Apple" in table_data["text"]
     print(doc_data)