🫡 Add timeout to capture download

reworkd · Jan 21, 2025 · 9c0aa59 · 9c0aa59
1 parent 8566526
commit 9c0aa59
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/core/pyproject.toml b/core/pyproject.toml
@@ -1,6 +1,6 @@
 [project]
 name = "harambe-core"
-version = "0.59.3"
+version = "0.59.4"
 description = "Core types for harambe SDK 🐒🍌"
 authors = [
     { name = "Adam Watkins", email = "[email protected]" }

diff --git a/sdk/harambe/core.py b/sdk/harambe/core.py
@@ -235,13 +235,14 @@ async def capture_download(
         clickable: ElementHandle,
         override_filename: str | None = None,
         override_url: str | None = None,
+        timeout: float | None = None,
     ) -> DownloadMeta:
         """
         Capture the download of a click event. This will click the element, download the resulting file
         and apply some download handling logic from the observer to transform to a usable URL
         """
 
-        async with self.page.expect_download() as download_info:
+        async with self.page.expect_download(timeout=timeout) as download_info:
             await clickable.click()
         download = await download_info.value
 

diff --git a/sdk/pyproject.toml b/sdk/pyproject.toml
@@ -1,14 +1,14 @@
 [project]
 name = "harambe-sdk"
-version = "0.59.3"
+version = "0.59.4"
 description = "Data extraction SDK for Playwright 🐒🍌"
 authors = [
     { name = "Adam Watkins", email = "[email protected]" }
 ]
 requires-python = ">=3.11,<4.0"
 readme = "README.md"
 dependencies = [
-    "harambe_core==0.59.3",
+    "harambe_core==0.59.4",
     "playwright==1.47.0",
     "beautifulsoup4==4.12.3",
     "requests==2.32.3",