Deny past future duration filesize #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deny upload with `timestamp` is future Deny upload with `timestamp` is past older than year 1971 Deny upload with `duration` is more than 1 hour Deny upload with `fileSize` is more than 150MB for flac and 200MB for wav
rassokhin-s
suggested changes
Feb 13, 2024
Add minimum value to `duration` and `fileSize` Add test cases for `duration` and `fileSize` is 0 Add happy test cases for `duration` and `fileSize`
rassokhin-s
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ DoD
POST /uploadsreceivesdurationandfile_sizeto prevent a very long audio file #69 Add duration and file_size parameters into upload endpoint #71(use n/a when API docs (Release notes, etc) do not need to be updated)
📝 Summary
duration,fileSizeas Optional because this gonna be released before Uploader releaseduration,fileSizetoGET /uploadsparams.timestampis futuretimestampis past older than year 1971durationis more than 1 hourfileSizeis more than 150MB for flac and 200MB for wav