Merge pull request #645 from rfcx/fix-error-null-message

Add return and remove log
rfcx · Aug 21, 2024 · 6f3888e · 6f3888e
2 parents 6a79431 + f024d08
commit 6f3888e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/noncore/views/v1/models/guardian-audio.js b/noncore/views/v1/models/guardian-audio.js
@@ -38,14 +38,14 @@ exports.models = {
     // auto-generate the asset filepath if it's not stored in the url column
     const segment = await StreamSegment.findOne({ where: { stream_id: dbRow.Guardian.stream_id, start: dbRow.measured_at } })
     if (!segment) {
-      res.status(404).json({ msg: 'Recording not found' })
+      return res.status(404).json({ msg: 'Recording not found' })
     }
     const dateTimeString = dbRow.measured_at.toISOString().substr(0, 19).replace(/:/g, '-')
     const audioPath = `/${dateTimeString.substr(0, 4)}/${dateTimeString.substr(5, 2)}/${dateTimeString.substr(8, 2)}/${dbRow.Guardian.stream_id}/${segment.id}.${dbRow.Format.file_extension}`
     const audioStorageUrl = (dbRow.url == null)
       ? 's3://' + process.env.INGEST_BUCKET + audioPath
       : dbRow.url
-    console.info(audioStorageUrl)
+
     audioUtils.cacheSourceAudio(audioStorageUrl)
       .then(function ({ sourceFilePath }) {
         if ((dbRow.Format.file_extension === outputFileExtension) &&
@@ -93,7 +93,7 @@ exports.models = {
     // auto-generate the asset filepath if it's not stored in the url column
     const segment = await StreamSegment.findOne({ where: { stream_id: dbRow.Guardian.stream_id, start: dbRow.measured_at } })
     if (!segment) {
-      res.status(404).json({ msg: 'Recording not found' })
+      return res.status(404).json({ msg: 'Recording not found' })
     }
     const dateTimeString = dbRow.measured_at.toISOString().substr(0, 19).replace(/:/g, '-')
     const audioPath = `/${dateTimeString.substr(0, 4)}/${dateTimeString.substr(5, 2)}/${dateTimeString.substr(8, 2)}/${dbRow.Guardian.stream_id}/${segment.id}.${dbRow.Format.file_extension}`