-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a new node
package
#1151
Creating a new node
package
#1151
Conversation
Today, we have some node's functionality spread across the code base. This commit is about creating a new interface gathering generic node's functionality to be used in other packages and mocked in unit-testing.
Hi @TomerNewman. Thanks for your PR. I'm waiting for a rh-ecosystem-edge member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for openshift-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomerNewman, ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
46737ba
into
rh-ecosystem-edge:main
Summary
Today, we have some node's functionality spread across the code base. This commit is about creating a new interface gathering generic node's functionality to be used in other packages and mocked in unit-testing.
Related upstream PR
Link to the Kubernetes Kernel Module Management PR #844
cherry picked due to merge issues