Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new node package #1151

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Creating a new node package #1151

merged 1 commit into from
Jun 25, 2024

Conversation

TomerNewman
Copy link
Member

@TomerNewman TomerNewman commented Jun 24, 2024

Summary

Today, we have some node's functionality spread across the code base. This commit is about creating a new interface gathering generic node's functionality to be used in other packages and mocked in unit-testing.


Related upstream PR

Link to the Kubernetes Kernel Module Management PR #844

cherry picked due to merge issues

Today, we have some node's functionality spread across the code base.
This commit is about creating a new interface gathering generic node's
functionality to be used in other packages and mocked in unit-testing.
Copy link

openshift-ci bot commented Jun 24, 2024

Hi @TomerNewman. Thanks for your PR.

I'm waiting for a rh-ecosystem-edge member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit ea60e45
🔍 Latest deploy log https://app.netlify.com/sites/openshift-kmm/deploys/66792dc3ee7b290008b9e6f7
😎 Deploy Preview https://deploy-preview-1151--openshift-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mresvanis
Copy link
Member

/ok-to-test

@yevgeny-shnaidman
Copy link
Member

/ok-to-test

@ybettan
Copy link
Member

ybettan commented Jun 25, 2024

/approve
/assign @yevgeny-shnaidman

Copy link

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomerNewman, ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yevgeny-shnaidman
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 46737ba into rh-ecosystem-edge:main Jun 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants