Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go.uber.org/mock from 0.4.0 to 0.5.0 #1299

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 13, 2025

Bumps go.uber.org/mock from 0.4.0 to 0.5.0.

Release notes

Sourced from go.uber.org/mock's releases.

v0.5.0

0.5.0 (15 Oct 2024)

Added

  • #153[]: Add --write_command_comment flag to specify whether to include Generated by this command comment.
  • #191[]: Add --build_constraint flag to add //go:build directives to generated mocks
  • #214[]: Add gob mode to support custom package loading techniques in place of --exec_only

Changed

  • #181[]: Made mockgen faster by changing flags passed to go list.
  • #183[]: Made Cond matcher generic.
  • #204[]: Removed ISGOMOCK() from generated mocks.
  • #207[]: Deprecated reflect mode and replaced it with the new package mode.

Fixed

  • #144[]: Fix a deadlock that can happen when mocking an interface that matches fmt.Stringer.
  • #168[]: Fix an issue where the "generated by" comment was being included in the package comment of generated mocks.

#144: uber-go/mock#144 #153: uber-go/mock#153 #168: uber-go/mock#168 #181: uber-go/mock#181 #183: uber-go/mock#183 #191: uber-go/mock#191 #204: uber-go/mock#204 #207: uber-go/mock#207 #214: uber-go/mock#214

Thanks to @​tulzke @​JacobOaks @​ARR4N @​sashamelentyev @​sywhang @​fasmat @​eyasy1217 @​ghouscht @​tie @​Neo2308 @​carson-brill @​alexandear @​sodul @​nbgraham for their contributions this release.

Changelog

Sourced from go.uber.org/mock's changelog.

0.5.0 (15 Oct 2024)

Added

  • #153[]: Add --write_command_comment flag to specify whether to include Generated by this command comment.
  • #191[]: Add --build_constraint flag to add //go:build directives to generated mocks
  • #214[]: Add gob mode to support custom package loading techniques in place of --exec_only

Changed

  • #181[]: Made mockgen faster by changing flags passed to go list.
  • #183[]: Made Cond matcher generic.
  • #204[]: Removed ISGOMOCK() from generated mocks.
  • #207[]: Deprecated reflect mode and replaced it with the new package mode.

Fixed

  • #144[]: Fix a deadlock that can happen when mocking an interface that matches fmt.Stringer.
  • #168[]: Fix an issue where the "generated by" comment was being included in the package comment of generated mocks.

#144: uber-go/mock#144 #153: uber-go/mock#153 #168: uber-go/mock#168 #181: uber-go/mock#181 #183: uber-go/mock#183 #191: uber-go/mock#191 #204: uber-go/mock#204 #207: uber-go/mock#207 #214: uber-go/mock#214

Thanks to @​tulzke @​JacobOaks @​ARR4N @​sashamelentyev @​sywhang @​fasmat @​eyasy1217 @​ghouscht @​tie @​Neo2308 @​carson-brill @​alexandear @​sodul @​nbgraham for their contributions this release.

Commits
  • a9c44d9 Release v0.5.0 (#213)
  • d164a16 Add gob mode to support custom package loading techniques in place of `--exec...
  • d01ed30 deprecated reflect mode has been replaced with package mode (#207)
  • 6d5eb71 Regenerate generated mocks (#206)
  • 8adc9de feat: mockgen flag --build_constraint to add //go:build directives (#191)
  • c50d83c Support Go 1.22 and Go 1.23 (#203)
  • 33ccc99 Avoid stringer-related deadlocks without adding ISGOMOCK (#204)
  • 60372e3 chore: gofumpt -w . (#202)
  • 70a5e8c Clarify documentation on Finish (#194)
  • ec32d99 Bump goreleaser/goreleaser-action from 4 to 6 (#182)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jan 13, 2025
@openshift-ci openshift-ci bot requested review from chr15p and ybettan January 13, 2025 17:15
Copy link

coderabbitai bot commented Jan 13, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

openshift-ci bot commented Jan 13, 2025

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a rh-ecosystem-edge member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit 627472a
🔍 Latest deploy log https://app.netlify.com/sites/openshift-kmm/deploys/678d63d1b5ae46000860823b
😎 Deploy Preview https://deploy-preview-1299--openshift-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dependabot dependabot bot force-pushed the dependabot/go_modules/go.uber.org/mock-0.5.0 branch from 69eea0f to 2779bee Compare January 15, 2025 08:03
@ybettan
Copy link
Collaborator

ybettan commented Jan 15, 2025

/ok-to-test
/approve
/assign @yevgeny-shnaidman @TomerNewman

Copy link

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yevgeny-shnaidman
Copy link
Member

/test images

@dependabot dependabot bot force-pushed the dependabot/go_modules/go.uber.org/mock-0.5.0 branch 3 times, most recently from 1e651af to 27afa4c Compare January 19, 2025 15:01
Bumps [go.uber.org/mock](https://github.com/uber/mock) from 0.4.0 to 0.5.0.
- [Release notes](https://github.com/uber/mock/releases)
- [Changelog](https://github.com/uber-go/mock/blob/main/CHANGELOG.md)
- [Commits](uber-go/mock@v0.4.0...v0.5.0)

---
updated-dependencies:
- dependency-name: go.uber.org/mock
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/go.uber.org/mock-0.5.0 branch from 27afa4c to 627472a Compare January 19, 2025 20:42
@ybettan
Copy link
Collaborator

ybettan commented Jan 20, 2025

@yevgeny-shnaidman PTAL

@yevgeny-shnaidman
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 20, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 6dff3af into main Jan 20, 2025
20 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/go.uber.org/mock-0.5.0 branch January 20, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file go Pull requests that update Go code lgtm ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants