Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Go 1.20 #874

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

qbarrand
Copy link
Contributor

@qbarrand qbarrand commented Nov 8, 2023

Use errors.Join instead of multierror.

Fixes #712
Fixes #873

/cc @yevgeny-shnaidman

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit 2049978
🔍 Latest deploy log https://app.netlify.com/sites/openshift-kmm/deploys/654b90dacf88690008787c81
😎 Deploy Preview https://deploy-preview-874--openshift-kmm.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 8, 2023
@qbarrand
Copy link
Contributor Author

qbarrand commented Nov 8, 2023

Requires openshift/release#45422 to be merged first.

@yevgeny-shnaidman
Copy link
Member

lint is failing because of fmt

Use errors.Join instead of multierror.
Copy link

openshift-ci bot commented Nov 8, 2023

@qbarrand: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 2049978 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yevgeny-shnaidman
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 8, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 0ec0c24 into rh-ecosystem-edge:main Nov 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to errors.Join when we move to Go 1.20
2 participants