Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to controller-runtime v0.16.3 #888

Conversation

qbarrand
Copy link
Contributor

Remove the kube-rbac-proxy container in the operator Deployment as the controller's metrics server can now authenticate and authorize clients on its own.
Serve metrics over TLS on port 8443; disable HTTP/2 by default.

Fixes #778

/cc @yevgeny-shnaidman @ybettan @chr15p

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit e49cf34
🔍 Latest deploy log https://app.netlify.com/sites/openshift-kmm/deploys/6555f77428db4a0008529ecd
😎 Deploy Preview https://deploy-preview-888--openshift-kmm.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

openshift-ci bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Remove the kube-rbac-proxy container in the operator Deployment as the
controller's metrics server can now authenticate and authorize clients
on its own.
Serve metrics over TLS on port 8443; disable HTTP/2 by default.

Upstream-Commit: de6e33e
@qbarrand qbarrand force-pushed the cp-de6e33e1b5562801f0c1a74f956f9f7f3384b468 branch from 9127f08 to e49cf34 Compare November 16, 2023 11:05
Copy link

openshift-ci bot commented Nov 16, 2023

@qbarrand: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security e49cf34 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chr15p
Copy link
Collaborator

chr15p commented Nov 16, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 16, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit d2e7cc0 into rh-ecosystem-edge:main Nov 16, 2023
5 checks passed
@qbarrand qbarrand deleted the cp-de6e33e1b5562801f0c1a74f956f9f7f3384b468 branch November 16, 2023 18:31
@chr15p chr15p mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cherry-picking error for de6e33e1b5562801f0c1a74f956f9f7f3384b468
2 participants