Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.0] re-fixing DevicePlugin upgrade from v1.1 to v2 #969

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #968

/assign qbarrand

Unlike upstream, in downstream version ModuleLoader daemonset differs
from DevicePlugin by present of the kernel version label, and not by
role label.
This PR changes the identification of DevicePlugins during gathering
all device plugin DS by checkig the absence of the kernel version label
Copy link

openshift-ci bot commented Jan 17, 2024

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a rh-ecosystem-edge member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qbarrand
Copy link
Contributor

qbarrand commented Jan 17, 2024

MGMT-16246
/lgtm
/ok-to-test
/assign @yevgeny-shnaidman

@yevgeny-shnaidman
Copy link
Member

/approve

Copy link

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 808d00d into rh-ecosystem-edge:release-2.0 Jan 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants