Fix get_openshift_image_trusted_certs bug
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test baremetalds-sno-recert-cluster-rename |
|
/test e2e-aws-ovn-single-node-recert-parallel |
1b831fa introduced a bug, this fixes it. It was simply reading from the wrong JSON pointer. This is only a problem in clusters that have custom certificates set in their OpenShift Image config
|
/test baremetalds-sno-recert-cluster-rename |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eranco74, omertuc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1b831fa introduced a bug, this fixes
it. It was simply reading from the wrong JSON pointer.
This is only a problem in clusters that have custom certificates set in
their OpenShift Image config