MGMT-16961: Support replacing the IP on the filesystem #147
Conversation
|
@tsorya: This pull request references MGMT-16961 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tsorya: This pull request references MGMT-16961 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tsorya
force-pushed
the
igal/ip_fs_rename
branch
2 times, most recently
from
c959043 to
abde398
Compare
tsorya
force-pushed
the
igal/ip_fs_rename
branch
2 times, most recently
from
b81a16f to
9c2302b
Compare
|
/retest |
Till this PR recert only updates the IP in etcd and we rely on LCA to update the filesystem. This code adds logic to update ip in all required files inside /etc/kubernetes. We replace old ip with new one file by file.
|
/test baremetalds-sno-recert-cluster-rename |
1 similar comment
|
/test baremetalds-sno-recert-cluster-rename |
|
Manually tested this PR and it seems to work as expected. CI is also quite happy. 🚀 /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mresvanis, tsorya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit eac0186
into
rh-ecosystem-edge:main
MGMT-16961: Support replacing the IP on the filesystem
Till this PR recert only updated IP in etcd and we relied on LCA to update the filesystem. This code adds logic to update ip in all required files inside /etc/kubernetes. We replace old ip with new one file by file.