Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid pem::encode_many_config because of duplicate newlines #66

Closed
wants to merge 1 commit into from

Conversation

omertuc
Copy link
Member

@omertuc omertuc commented Dec 5, 2023

We re-implement encode_many_config ourselves without the excess newlines

We re-implement encode_many_config ourselves without the excess newlines
Copy link

openshift-ci bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omertuc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@omertuc
Copy link
Member Author

omertuc commented Dec 5, 2023

/test ?

Copy link

openshift-ci bot commented Dec 5, 2023

@omertuc: The following commands are available to trigger required jobs:

  • /test 4.14-images
  • /test 4.15-images
  • /test baremetalds-sno-recert-cluster-rename
  • /test cargo-check
  • /test cargo-clippy
  • /test e2e-aws-ovn-single-node-recert-openshift-e2e-test-qe
  • /test e2e-aws-ovn-single-node-recert-parallel
  • /test e2e-aws-ovn-single-node-recert-serial
  • /test images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-rh-ecosystem-edge-recert-main-4.14-images
  • pull-ci-rh-ecosystem-edge-recert-main-4.15-images
  • pull-ci-rh-ecosystem-edge-recert-main-cargo-check
  • pull-ci-rh-ecosystem-edge-recert-main-cargo-clippy
  • pull-ci-rh-ecosystem-edge-recert-main-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@omertuc
Copy link
Member Author

omertuc commented Dec 5, 2023

/test baremetalds-sno-recert-cluster-rename
/test e2e-aws-ovn-single-node-recert-parallel
/test e2e-aws-ovn-single-node-recert-serial

@omertuc
Copy link
Member Author

omertuc commented Dec 5, 2023

/test e2e-aws-ovn-single-node-recert-parallel
/test e2e-aws-ovn-single-node-recert-serial

@omertuc
Copy link
Member Author

omertuc commented Dec 6, 2023

/test e2e-aws-ovn-single-node-recert-serial

@omertuc
Copy link
Member Author

omertuc commented Dec 6, 2023

Closing in favor of #67

@omertuc omertuc closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant