Merge main into v0 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When renaming, the array was accidentally replaced by a string, this caused a KCM rollout
KCM extended arguments should be an array
The newline is causing a rollout that we wish to avoid
Add a newline at the end of the kcm pod configmap
Cachito doesn't do Rust, so we have to vendor all of our dependencies. We're doing Vendoring using [`cargo vendor-filterer`](https://github.com/coreos/cargo-vendor-filterer) because otherwise regular cargo pulls in a lot of heavy dependencies that are Windows only, which will make the git repo very big for a tool that is used in Linux only.
Enable vendoring
As opposed to file paths. This will allow recert to be launched without having all the keys laid out carefully in files, which is inconvenient if they aren't already in files
`RECERT_CONFIG` accept keys inlined raw inside the config
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omertuc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't expect any problems