MGMT-16781: Implement ocp postprocess IP rename #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omertuc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test baremetalds-sno-recert-cluster-rename |
omertuc
added a commit
to omertuc/lifecycle-agent
that referenced
this pull request
Feb 5, 2024
Similar to b6c5db1 but for IP instead of hostname This change leverages recert's latest OCP post-process IP feature, which makes OCP's control-plane cluster operators (i.e. etcd, kube-apiserver, authentication, etc) happy, so that they won't trigger additional revisions. Thus reducing the time OCP needs to stabilize after recert. For more details please check here: - rh-ecosystem-edge/recert#89
This change ensures that unnecessary and time-consuming OCP
control-plane component rollouts are skipped. They are triggered by the
node's IP change, which occurs when applying an IBU seed image onto the
target SNO.
Specifically, the changes are:
- add a new recert configuration argument of type string, i.e.
--ip with which the new ip is provided
- add an ip_rename mod, which implements the following changes:
- replace all occurrences of the previous (seed node) ip in etcd
- replace all occurrences of the previous (seed node) ip in the
filesystem (this is currently just a stub, since it's [done](https://github.com/openshift-kni/lifecycle-agent/blob/3f447f629cf73a25a350c1c2cc88d95bf2a31956/lca-cli/postpivot/postpivot.go#L232-L236) by LCA already)
|
/test baremetalds-sno-recert-cluster-rename |
|
@omertuc: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
omertuc
added a commit
to omertuc/lifecycle-agent
that referenced
this pull request
Feb 6, 2024
Similar to b6c5db1 but for IP instead of hostname This change leverages recert's latest OCP post-process IP feature, which makes OCP's control-plane cluster operators (i.e. etcd, kube-apiserver, authentication, etc) happy, so that they won't trigger additional revisions. Thus reducing the time OCP needs to stabilize after recert. For more details please check here: - rh-ecosystem-edge/recert#89 Also stop deleting `etcd-endpoints` since now they're fixed by recert, and if you delete them you get a rollout
mresvanis
changed the title
omertuc
added a commit
to omertuc/lifecycle-agent
that referenced
this pull request
Feb 6, 2024
Similar to b6c5db1 but for IP instead of hostname This change leverages recert's latest OCP post-process IP feature, which makes OCP's control-plane cluster operators (i.e. etcd, kube-apiserver, authentication, etc) happy, so that they won't trigger additional revisions. Thus reducing the time OCP needs to stabilize after recert. For more details please check here: - rh-ecosystem-edge/recert#89 Also stop deleting `etcd-endpoints` since now they're fixed by recert, and if you delete them you get a rollout
omertuc
added a commit
to omertuc/lifecycle-agent
that referenced
this pull request
Feb 6, 2024
Similar to b6c5db1 but for IP instead of hostname This change leverages recert's latest OCP post-process IP feature, which makes OCP's control-plane cluster operators (i.e. etcd, kube-apiserver, authentication, etc) happy, so that they won't trigger additional revisions. Thus reducing the time OCP needs to stabilize after recert. For more details please check here: - rh-ecosystem-edge/recert#89 Also stop deleting `etcd-endpoints` since now they're fixed by recert, and if you delete them you get a rollout
jc-rh
pushed a commit
to jc-rh/lifecycle-agent
that referenced
this pull request
Feb 14, 2024
Similar to b6c5db1 but for IP instead of hostname This change leverages recert's latest OCP post-process IP feature, which makes OCP's control-plane cluster operators (i.e. etcd, kube-apiserver, authentication, etc) happy, so that they won't trigger additional revisions. Thus reducing the time OCP needs to stabilize after recert. For more details please check here: - rh-ecosystem-edge/recert#89 Also stop deleting `etcd-endpoints` since now they're fixed by recert, and if you delete them you get a rollout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that unnecessary and time-consuming OCP
control-plane component rollouts are skipped. They are triggered by the
node's IP change, which occurs when applying an IBU seed image onto the
target SNO.
Specifically, the changes are:
--ip with which the new ip is provided
filesystem (this is currently just a stub, since it's done by LCA already)