Proxy rename support #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omertuc
force-pushed
the
proxy
branch
3 times, most recently
from
5623444 to
8fce6af
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omertuc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test baremetalds-sno-recert-cluster-rename |
eranco74
reviewed
Mar 21, 2024
omertuc
force-pushed
the
proxy
branch
2 times, most recently
from
1c4e23b to
7680c6a
Compare
mresvanis
reviewed
Mar 25, 2024
mresvanis
reviewed
Mar 25, 2024
omertuc
force-pushed
the
proxy
branch
3 times, most recently
from
87a1722 to
05a6437
Compare
MGMT-16796 Added new proxy option that sets the cluster proxy to the desired configuration. Proxy editing with recert is required to avoid rollouts / reboots Also added an install-config option that sets the install-config value in the install-config configmaps, this is needed because Cluster Network Operator tries to calculate the no_proxy value from these, so we need to modify them to match the installed/upgraded cluster
|
/lgtm |
openshift-merge-bot
bot
merged commit ac4312f
into
rh-ecosystem-edge:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MGMT-16796
See commit message