Merge main into v0 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that unnecessary and time-consuming OCP
control-plane component rollouts are skipped. They are triggered by the
node's IP change, which occurs when applying an IBU seed image onto the
target SNO.
Specifically, the changes are:
- add a new recert configuration argument of type string, i.e.
--ip with which the new ip is provided
- add an ip_rename mod, which implements the following changes:
- replace all occurrences of the previous (seed node) ip in etcd
- replace all occurrences of the previous (seed node) ip in the
filesystem (this is currently just a stub, since it's [done](https://github.com/openshift-kni/lifecycle-agent/blob/3f447f629cf73a25a350c1c2cc88d95bf2a31956/lca-cli/postpivot/postpivot.go#L232-L236) by LCA already)
Implement ocp postprocess IP rename
Accidentally user cluster_domain where it should have been the infra-ID, this caused a KCM rollout
Typo in hostname rename
Fix etcd rollout
These annotations could be a cause for rollouts, so for now avoid them as avoiding rollout is more important than having those annotations
Fix KCM rollout
Disable recert-edited annotations
We don't want to silently ignore them, it defeats user expectations
Unknown config keys should be an error
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mresvanis The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test baremetalds-sno-recert-cluster-rename |
|
It's just fast forward, no need for CI, since it already ran on main, no novel merge commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR is merged we can go ahead and revert this LCA PR.