-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose commit hook #225
Expose commit hook #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Found the commented issue on reading through your changes.
If you can please rebuild dist/ with EMSDK 3.1.61 that will make it easier for me to verify your binaries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can build byte-for-byte identical binaries.
Just fix these cosmetic nits and I'll merge.
Checklist
non-exclusive, royalty-free, irrevocable copyright license to reproduce, prepare
derivative works of, publicly display, sublicense, and distribute this
Contribution and such derivative works.
Contribution contains no content requiring a license from any third party.
I made this PR largely by copying #210 and trusting tests. I just now switched a project to use my fork, and
commit_hook()
appears to be working as expected.I think we could add the rollback hook very easily with this work, but I didn't need that. If you want that feature here, I'd be happy to implement it.
I committed a build made using Emscripten 3.1.70.