Skip to content

Commit

Permalink
fixes to previous commit (to be squashed)
Browse files Browse the repository at this point in the history
- removed leftover debug messages from test_fsset.py
- removed unused imports from fsset.py
- changed variable's names to correct values in root.py
  • Loading branch information
japokorn committed Aug 8, 2024
1 parent 59c7535 commit 1ef59a0
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
7 changes: 3 additions & 4 deletions pyanaconda/modules/storage/devicetree/fsset.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,13 @@

from blivet import blockdev
from blivet.fstab import FSTabManager
from blivet.devices import NoDevice, DirectoryDevice, NFSDevice, FileDevice, MDRaidArrayDevice, \
from blivet.devices import NoDevice, DirectoryDevice, FileDevice, MDRaidArrayDevice, \
NetworkStorageDevice, OpticalDevice
from blivet.errors import UnrecognizedFSTabEntryError, FSTabTypeMismatchError, SwapSpaceError
from blivet.formats import get_format, get_device_format_class
from blivet.errors import UnrecognizedFSTabEntryError, SwapSpaceError
from blivet.formats import get_format
from blivet.storage_log import log_exception_info

from pyanaconda.core.configuration.anaconda import conf
from pyanaconda.core.i18n import _
from pyanaconda.modules.storage.platform import platform, EFI

from pyanaconda.anaconda_loggers import get_module_logger
Expand Down
4 changes: 2 additions & 2 deletions pyanaconda/modules/storage/devicetree/root.py
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,8 @@ def _parse_fstab(devicetree, chroot):
continue

# If a btrfs volume is found but a subvolume is expected, ignore the volume.
if device.type == "btrfs volume" and "subvol=" in options:
log.debug("subvolume from %s for %s not found", options, devspec)
if device.type == "btrfs volume" and "subvol=" in entry.mntops:
log.debug("subvolume from %s for %s not found", entry.mntops, entry.spec)
continue

if entry.vfstype != "swap":
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,3 @@ def test_root_parse_fstab(self):

self.assertEqual(mounts["/mnt/testmount"], test_dev)
self.assertTrue(test_dev in devices)

print("MYDEBUG: %s" % mounts)
print("MYDEBUG: %s" % devices)

0 comments on commit 1ef59a0

Please sign in to comment.