Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istio annotation deprecated to use label #90

Merged
merged 2 commits into from
Feb 7, 2024
Merged

istio annotation deprecated to use label #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbb3db5
istio annotation deprecated to use label
victor-smg Feb 7, 2024
b742bca
add label
victor-smg Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/imaginary/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
appVersion: "1.2.4"
description: Deploy imaginary to process pictures on the fly
name: imaginary
version: 0.2.2
version: 0.2.3
home: https://github.com/h2non/imaginary
sources:
- https://github.com/ricardo-ch/helm-charts/tree/main/charts/imaginary
Expand All @@ -15,7 +15,7 @@ keywords:
- h2non
annotations:
artifacthub.io/changes: |
- "Rename templates/seccret_tls.yaml to templates/secret_tls.yaml"
- "Change 'sidecar.istio.io/inject' annotation to label to following istio change"
artifacthub.io/images: |
- name: imaginary
image: h2non/imaginary:1.2.4
2 changes: 1 addition & 1 deletion charts/imaginary/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# imaginary

![Version: 0.2.2](https://img.shields.io/badge/Version-0.2.2-informational?style=flat-square) ![AppVersion: 1.2.4](https://img.shields.io/badge/AppVersion-1.2.4-informational?style=flat-square) ![Release Status](https://github.com/ricardo-ch/helm-charts/workflows/Release%20Charts/badge.svg) [![License](https://img.shields.io/github/license/ricardo-ch/helm-charts)](https://github.com/ricardo-ch/helm-charts/blob/main/LICENSE)
![Version: 0.2.3](https://img.shields.io/badge/Version-0.2.3-informational?style=flat-square) ![AppVersion: 1.2.4](https://img.shields.io/badge/AppVersion-1.2.4-informational?style=flat-square) ![Release Status](https://github.com/ricardo-ch/helm-charts/workflows/Release%20Charts/badge.svg) [![License](https://img.shields.io/github/license/ricardo-ch/helm-charts)](https://github.com/ricardo-ch/helm-charts/blob/main/LICENSE)

This chart installs [Imaginary](https://github.com/h2non/imaginary).

Expand Down
4 changes: 3 additions & 1 deletion charts/imaginary/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@ spec:
{{- range $key, $value := .Values.additionalLabels }}
{{ $key }}: {{ $value }}
{{- end }}
annotations:
{{- if .Values.istio.inject }}
sidecar.istio.io/inject: {{ quote .Values.istio.inject }}
{{- end }}
annotations:
{{- if .Values.istio.inject }}
sidecar.istio.io/proxyCPU: {{ .Values.istio.cpu }}
{{- if .Values.istio.cpuLimit }}
sidecar.istio.io/proxyCPULimit: {{ .Values.istio.cpuLimit }}
Expand Down
Loading