staticcheck

index.go

@@ -172,7 +172,7 @@ func (idx *Index) addFromWorkTree(f *FileStatus) error {
 func (idx *Index) updateItem(i *indexItem) error {
 	found := false
 	for k, v := range idx.items {
-		if bytes.Compare(v.Name, i.Name) == 0 {
+		if bytes.Equal(v.Name, i.Name) {
 			idx.items[k] = i
 			found = true
 		}

object.go

@@ -446,6 +446,9 @@ func CommittedFilesForBranchHead(name string) (*FfileSet, error) {
 		return nil, err
 	}
 	fs, err := CommittedFiles(commitSha)
+	if err != nil {
+		return nil, err
+	}
 	return NewFfileSet(fs, nil, nil)
 }
 

sha.go

@@ -37,7 +37,7 @@ func ShaFromHexString(s string) (Sha, error) {
 }
 
 func (s Sha) Matches(ss Sha) bool {
-	return bytes.Compare(s.hash[:], ss.hash[:]) == 0
+	return bytes.Equal(s.hash[:], ss.hash[:])
 }
 
 func (s Sha) String() string {

switch.go

@@ -23,6 +23,9 @@ func newSwitchBranchDelta(name string) (*switchBranchDelta, error) {
 	// get all files in working directory, index and current commit with the
 	// index and wd statuses set.
 	curFiles, err := CurrentStatus()
+	if err != nil {
+		return nil, err
+	}
 
 	// get all the files in the branch HEAD commit being switched to
 	commitFiles, err := CommittedFilesForBranchHead(name)