Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 153, .jp domains #225

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Conversation

mzpqnxow
Copy link
Contributor

This aims to address #153

With these changes, things are a little better, perhaps not perfect though. Good enough to merge? Your call

Also, note that this changes the default behavior for .jp domains in whois.py, by adding /e by default - which may not be desired

Output with this change made:

{
  "domain_name": "WOWKOREA.JP",
  "registrant_org": "AISE,Inc",
  "organization_type": null,
  "creation_date": "2006-08-22 00:00:00",
  "technical_contact_name": null,
  "administrative_contact_name": "WHOIS co, ltd.",
  "administrative_contact_email": "[email protected]",
  "administrative_contact_phone": "03-5379-1705",
  "administrative_contact_fax": "03-5379-1709",
  "administrative_contact_post_code": "160-0004",
  "administrative_contact_postal_address": "4-13-17 Yotuya,Shinjyuku-ku,Tokyo",
  "expiration_date": "2024-08-31 00:00:00",
  "name_servers": [
    "ns1.whois.ne.jp",
    "ns2.whois.ne.jp",
    "ns1.whoisweb.jp",
    "ns2.whoisweb.jp"
  ],
  "updated_date": "2023/11/12 08:06:07 (JST)",
  "signing_key": null,
  "status": "Active"
}

Also:

{
  "domain_name": "NINTENDO.JP",
  "registrant_org": "Nintendo Co., Ltd.",
  "organization_type": null,
  "creation_date": "2001-03-26 00:00:00",
  "technical_contact_name": null,
  "administrative_contact_name": "Intellectual Property Department",
  "administrative_contact_email": "[email protected]",
  "administrative_contact_phone": "075-662-9600",
  "administrative_contact_fax": null,
  "administrative_contact_post_code": "[Postal Address]",
  "administrative_contact_postal_address": "[Phone]                         075-662-9600",
  "expiration_date": "2025-03-31 00:00:00",
  "name_servers": [
    "ns-1825.awsdns-36.co.uk",
    "ns-1209.awsdns-23.org",
    "ns-972.awsdns-57.net",
    "ns-197.awsdns-24.com"
  ],
  "updated_date": "2024/04/01 01:05:04 (JST)",
  "signing_key": null,
  "status": "Active"
}

Adam Greene and others added 2 commits June 7, 2024 11:14
@mzpqnxow mzpqnxow mentioned this pull request Jun 10, 2024
Copy link
Contributor Author

@mzpqnxow mzpqnxow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally copied an exception over that doesn't exist in pywhois, it's fixed now

CI checks caught it! :)

@richardpenman
Copy link
Owner

Thanks for this!

@richardpenman richardpenman merged commit 5958d0d into richardpenman:master Jun 10, 2024
3 checks passed
@mzpqnxow mzpqnxow deleted the jp-domain branch June 16, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants