socktap: fix packet size in TcpLink #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riebl
reviewed
Nov 13, 2023
tools/socktap/tcp_link.cpp
Outdated
| @@ -31,6 +31,9 @@ void TcpLink::request(const access::DataRequest& request, std::unique_ptr<ChunkP | |||
|
|
|||
| // insert packet size before ethernet header | |||
| uint16_t packet_size = packet->size() + EthernetHeader::length_bytes; | |||
There was a problem hiding this comment.
I think the fix should be replacing packet->size() by packet->size(OsiLayer::Network, OsiLayer::Application).
There was a problem hiding this comment.
Yes, that is a more elegant solution. I didn't know about this function.
|
Thanks, I have squashed your PR and merged it per 711e424. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the router forwards a packet, the packet is duplicated and therefore a link layer is already present.
In this case, the packet-size calculation would count the link layer twice.