-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored markup file loader to be extensible by third-party libraries #1312
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this, I think we can just import IEnumerable<IMarkupFileLoader>
from DI. It's harder to control the order of registration that way, but it shouldn't matter in most cases (the loader prefixes should be distinct)
It's not that easy - the Hot Reload is done also by a special loader which basically decorates the default file-system loader. |
I've been looking at this again, and the problem is that the order of services returned by
I see two ways how to solve the issue:
|
You can keep the |
Currently, it was not possible to extend the
AggregateMarkupFileLoader
to support special pages (similar toembedded://...
format and so on).I've created
AggregateMarkupFileOptions
which specifies the types and the order of concrete markup file loaders.These loaders must be registered in DI, but anyone can add custom loaders like this: